Replace ImageList with QListWidget implementation #1670
Conversation
|
can you add a brief description why the new implementation is better? e.g., Before/After screenshots. i.e., is this a feature or refactoring? 
|
There was a problem hiding this comment.
thank you for your pr @XuKang371322, and congrats on making the first one.
.gitignore
Outdated
| .DS_Store | ||
| .idea/ | ||
| /.vscode | ||
| /run.py |
There was a problem hiding this comment.
Thanks! Those were my local editor files. Removed the .vscode and updated the PR.
labelme/app.py
Outdated
| self.importDirImages(filename, load=False) | ||
| else: | ||
| self.filename = filename | ||
| self.filename:str|types.NoneType = filename |
There was a problem hiding this comment.
can you add from __future__ import annotations so that this is compatible with python3.9
There was a problem hiding this comment.
Thanks for the tip! I've added from future import annotations to the files for 3.9 compatibility.
This is a refactoring for better performance and clarity. |
2 participants
I made the following changes:
len(ImageList) >> fileListWidget.countImageList.index(text) >> findListRow(text)ImageList[text] >> fileListWidget.findItems(text)This is my first time submitting a PR to this project. Thank you for the opportunity to contribute. If there are any issues with my code or the PR process, or if any changes are needed, please don't hesitate to let me know. I'm more than happy to learn and make revisions. Thank you for your time and review!